Restore Snap Support #350
Closed
Restore Snap Support #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alter cmake file and snapcraft.yaml to build snap builds once more. Due to core22 not supporting qmake yet [1] and Qt not continuing to support qmake, this commit moves Packet Sender snap builds to cmake. In order to not mess with Debian builds (Which use the existing CMakeLists.txt), a variable SNAP has to be defined and set to a truthy value in order to do snap-specific changes. The alterations were generated by using qmake2cmake [3] on the .pro file for snap builds, and then merged under if statements for the existing CMakeLists.txt. I did have to comment out the git sha generation and add that back manually for the tool to work [1] https://forum.snapcraft.io/t/core22-qmake-plugin-support/35026 [2] https://www.qt.io/blog/2019/08/07/technical-vision-qt-6 [3] https://code.qt.io/cgit/qt/qmake2cmake.git/about/
|
Please move the snap stuff to a separate directory. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alter cmake file and snapcraft.yaml to build snap builds once more. Due to core22 not supporting qmake yet [1] and Qt not continuing to support qmake, this commit moves Packet Sender snap builds to cmake. In order to not mess with Debian builds (Which use the existing CMakeLists.txt), a variable SNAP has to be defined and set to a truthy value in order to do snap-specific changes.
The alterations were generated by using qmake2cmake [3] on the .pro file for snap builds, and then merged under if statements for the existing CMakeLists.txt. I did have to comment out the git sha generation and add that back manually for the tool to work
[1] https://forum.snapcraft.io/t/core22-qmake-plugin-support/35026
[2] https://www.qt.io/blog/2019/08/07/technical-vision-qt-6
[3] https://code.qt.io/cgit/qt/qmake2cmake.git/about/
Before submitting a pull request: